Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade qt: compute SHA if not available #72

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Sep 28, 2023

tested on qt 6.5.3

@danimtb
Copy link
Member

danimtb commented Sep 29, 2023

Hi @ericLemanissier, thanks for the PR. This is needed when there are no hashes in the meta4 files right? Is this the case in qt 6.5.3?

@ericLemanissier
Copy link
Contributor Author

yes, this is the case for few hours after a release.
Yesterday:

<?xml version="1.0" encoding="UTF-8"?>
<metalink xmlns="urn:ietf:params:xml:ns:metalink">
  <generator>MirrorBrain/2.19.0</generator>
  <origin dynamic="true">https://download.qt.io/official_releases/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz.meta4</origin>
  <published>2023-09-28T12:09:01Z</published>
  <publisher>
    <name>Qt Project</name>
    <url>https://download.qt.io</url>
  </publisher>

  <file name="qt-everywhere-src-6.5.3.tar.xz">
    <size>798402796</size>

    <!-- <mtime>1695875164</mtime> -->



    <!-- Found 2 mirrors: 0 in the same network prefix, 0 in the same autonomous system,
         0 handling this country, 1 in the same region, 1 elsewhere -->

    <!-- Mirrors in the same network (90.127.0.0/16): -->

    <!-- Mirrors in the same AS (3215): -->

    <!-- Mirrors which handle this country (FR): -->

    <!-- Mirrors in the same continent (EU): -->
    <url location="de" priority="1">https://ftp.fau.de/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>

    <!-- Mirrors in the rest of the world: -->
    <url location="ke" priority="2">https://qtproject.mirror.liquidtelecom.com/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
  </file>
</metalink>

Today:

<?xml version="1.0" encoding="UTF-8"?>
<metalink xmlns="urn:ietf:params:xml:ns:metalink">
  <generator>MirrorBrain/2.19.0</generator>
  <origin dynamic="true">https://download.qt.io/official_releases/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz.meta4</origin>
  <published>2023-09-29T10:52:28Z</published>
  <publisher>
    <name>Qt Project</name>
    <url>https://download.qt.io</url>
  </publisher>

  <file name="qt-everywhere-src-6.5.3.tar.xz">
    <size>798402796</size>

    <!-- <mtime>1695875164</mtime> -->

    <!-- internal id: 1028268 -->
    <hash type="md5">755db0527410df135609b51defa1a689</hash>
    <hash type="sha-1">342a166d84e6270b07f1d7b36728eefd8c0ddb71</hash>
    <hash type="sha-256">7cda4d119aad27a3887329cfc285f2aba5da85601212bcb0aea27bd6b7b544cb</hash>
    <pieces length="262144" type="sha-1">
      <hash>d68455cb0d7ffd106b17cd51dc30d6013e93ff1c</hash>
      <hash>1c5bbb3cfcd76e898a23ccbed2b02dc7f93da002</hash>
      <hash>dc174b68e3cf1bf2f1de814a4b22aaf22006755a</hash>
      <hash>387a66bd1238c66056a3762ca188c5a56a6488ad</hash>
      ...
    </pieces>


    <!-- Found 19 mirrors: 0 in the same network prefix, 0 in the same autonomous system,
         0 handling this country, 10 in the same region, 8 elsewhere -->

    <!-- Mirrors in the same network (90.127.0.0/16): -->

    <!-- Mirrors in the same AS (3215): -->

    <!-- Mirrors which handle this country (FR): -->

    <!-- Mirrors in the same continent (EU): -->
    <url location="gb" priority="1">https://mirrors.20i.com/pub/qt.io/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="nl" priority="2">https://ftp.nluug.nl/languages/qt/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="de" priority="3">https://mirror.netcologne.de/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="gb" priority="4">https://mirrors.ukfast.co.uk/sites/qt.io/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="de" priority="5">https://qt-mirror.dannhauer.de/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="de" priority="6">https://ftp.fau.de/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="dk" priority="7">https://mirrors.dotsrc.org/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="pl" priority="8">https://ftp.icm.edu.pl/packages/qt/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="se" priority="9">https://ftp.acc.umu.se/mirror/qt.io/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="fi" priority="10">https://www.nic.funet.fi/pub/mirrors/download.qt-project.org/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>

    <!-- Mirrors in the rest of the world: -->
    <url location="ng" priority="11">https://mirror.web4africa.ng/qt/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="ke" priority="12">https://qtproject.mirror.liquidtelecom.com/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="us" priority="13">https://qt.mirror.constant.com/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="sg" priority="14">https://mirrors.cloud.tencent.com/qt/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="cn" priority="15">https://mirrors.ustc.edu.cn/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="cn" priority="16">https://mirrors.sjtug.sjtu.edu.cn/qt/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="jp" priority="17">https://ftp.jaist.ac.jp/pub/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
    <url location="jp" priority="18">https://ftp.yz.yamagata-u.ac.jp/pub/qtproject/archive/qt/6.5/6.5.3/single/qt-everywhere-src-6.5.3.tar.xz</url>
  </file>
</metalink>

@danimtb
Copy link
Member

danimtb commented Sep 29, 2023

Thanks for the report.
So, it is not needed anymore?

@ericLemanissier
Copy link
Contributor Author

it is not needed any more for 6.5.3, but it will be needed each time there is a new version of qt, if we want to be able to publish it before the metalink is completed with the sha (something like 12/24h after the release).
As far as I remember, I always had to download and compute the hash manually at the time I updated the conandata.yml, because the metalink did not contain the sha yet.

@ericLemanissier
Copy link
Contributor Author

@danimtb do you see a problem with this change ?

@ericLemanissier
Copy link
Contributor Author

WDYT @memsharded @RubenRBS @czoido ?

@ericLemanissier
Copy link
Contributor Author

@RubenRBS friendly ping

@AbrilRBS AbrilRBS self-assigned this Oct 24, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :)

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 24, 2023

Thanks @danimtb for pushing this to the finish line :)

@AbrilRBS AbrilRBS merged commit a6b7e6a into conan-io:main Oct 24, 2023
1 check passed
@ericLemanissier ericLemanissier deleted the patch-1 branch October 24, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants